Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BasicFullPageUI.java is not working as expected #28

Closed
pk1057 opened this issue Feb 3, 2017 · 2 comments
Closed

BasicFullPageUI.java is not working as expected #28

pk1057 opened this issue Feb 3, 2017 · 2 comments

Comments

@pk1057
Copy link

pk1057 commented Feb 3, 2017

Hello,
i tried your fantastic library and had big trouble to get the BasicFullPageUI running as expected.
It always showed up only with two button lines and not like described in the wiki.

So a compared the wiki and the test source code and found out that at the end of the init method
the file creates a panel and does a second setContent on the main layout overwriting the responsive layout.

When i removed this second setContent everything works as expected !

        setContent(responsiveLayout);

        Panel panel = new Panel("Panel");
-->         setContent(panel);
        ResponsiveLayout layout = new ResponsiveLayout(ResponsiveLayout.ContainerType.FLUID);
        panel.setContent(layout);
        layout.addRow()
                .withMargin(ResponsiveRow.MarginSize.SMALL)
                .withVerticalSpacing(ResponsiveRow.SpacingSize.SMALL, true)
                .withHorizontalSpacing(true)
                .addColumn().withDisplayRules(12, 12, 12, 12).setComponent(new Label("Test"));


    }
@pk1057 pk1057 changed the title BasicFullPageUI.java is not wrking as expected BasicFullPageUI.java is not working as expected Feb 3, 2017
@JarekToro
Copy link
Owner

Ah yes, thank you during last revision I was messing around with that page trying something and I forgot to put it back! Thanks for the heads up!

@JarekToro
Copy link
Owner

Fixed in latest release. Now on Vaadin Directory

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants