Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deco: Implement "should corner be rounded" detection #35

Closed
Javyre opened this issue Jul 31, 2021 · 4 comments
Closed

deco: Implement "should corner be rounded" detection #35

Javyre opened this issue Jul 31, 2021 · 4 comments

Comments

@Javyre
Copy link
Owner

Javyre commented Jul 31, 2021

Currently, corner radii >0 are pretty ugly and useless since it is blindly applied to every corner. We need to detect whether a corner should be rounded or not so as to avoid "holes" as described in #19 (comment)

@Javyre Javyre closed this as completed in f1157e9 Sep 2, 2021
@ErikReider
Copy link

So this should only round the outside corners (the corners closest to each display edge)?

@Javyre
Copy link
Owner Author

Javyre commented Sep 2, 2021

A setting could be added to round display-edge corners pretty easily, but in f1157e9 it only rounds outer corners of floating nodes (either single floating views or whole floating tiling trees)

@ErikReider
Copy link

Oh. I read my comment again and it didn't really make any sense 😅. I was wondering if this PR only rounds the corners of tiled windows that are the closest to each corner of the display to remove the gap in between each window

@Javyre
Copy link
Owner Author

Javyre commented Sep 2, 2021

Oh I see. Yes exactly. Except that the main tiling tree (i.e. non-floating trees) aren't rounded at all. (this last part is what I was saying could be made configurable if there is demand)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants