Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't pare several libraries, and issues with number parsing #9

Open
KFlash opened this issue Apr 20, 2018 · 0 comments
Open

Doesn't pare several libraries, and issues with number parsing #9

KFlash opened this issue Apr 20, 2018 · 0 comments

Comments

@KFlash
Copy link

KFlash commented Apr 20, 2018

I have noticed that this library can't parse TypScript and older editions of ember.js. I consider this a bug and not something that is not yet implemented or something that doesn't fail as it should according to the ECMA specs.

I further noticed a flaw in your numeric literal parsing. You seem to assume that all numbers - decimal, hex, octal, implicit octals etc - fits into 4 bytes.

In your code I see this: value = value * 8 + (codepoint - 0);

If your number length are equal to 10, 11, ... , 100, ... and so on, you will get a wrong result.

// J.K

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant