Use ReactDOM from window/global scope

[harlow]

Facebook's install page (https://github.com/facebook/react#installation) recommends including both React and ReactDOM from CDN.

<!-- The core React library -->
<script src="https://fb.me/react-0.14.0.js"></script>
<!-- The ReactDOM Library -->
<script src="https://fb.me/react-dom-0.14.0.js"></script>

By using this style we don't need to vendor ReactDOM directly. Would it make sense to do this:

var ReactDOM = (typeof window !== "undefined" ? window['ReactDOM'] : typeof global !== "undefined" ? global['ReactDOM'] : null);

Here:
https://github.com/JedWatson/react-select/blob/master/dist/react-select.js#L73

Thoughts?

[twe4ked]

👍

[wavejumper]

Another 👍 - would allow this library to work for other compile to js languages (eg clojurescript)

[TigerC10]

Count that +1 for 👍 - this killed react-select in my build system since I'm not leveraging browserify or requirejs (yet).

[sobrinho]

Another 👍, the component is broken on browsers without module loaders.

[bavardage]

👍

[l4u]

👍 When react-select is used with Bower and react-rails, it shows Error: Cannot find module 'react-dom'. When we can reuse window.ReactDOM, it works.

[dbkaplun]

+1

[twe4ked]

@JedWatson is there a reason not to do this?

[twe4ked]

Thanks, I'll give this a go now!

[JedWatson]

@twe4ked had to figure out the right way to do it without interfering with the other build processes and target environments. Done now, and I've added an updated usage example in examples/src/standalone.html

[twe4ked]

Actually I'm using bower so I'm not sure this will fix it for me. I'll have a look now.

Edit: Thanks for the explanation :)

[JedWatson]

I'll have to publish a new version before it works from bower, but you can test it by downloading the repo directly from npm and dropping the dist folder into your project (this is effectively what bower does anyway)

[sobrinho]

Thanks! \o/

[mockdeep]

Has this been released to bower yet? We just tried to plug it in alongside react-rails and got the same error as @l4u above.

[l4u]

@mockdeep Use the build at or after b2afb88

[mockdeep]

@l4u are you including it in your project assets or using rails-assets? We actually just ended up setting up browserify-rails and will probably move to using the npm package.

[l4u]

@mockdeep we have to wait for a new release v1.0.0-beta6 before we can use it with rails-assets (bower). Alternatively you can get the dist/react-select.js at b2afb88

[bondarevpavel]

Thanks! Using master branch for fixing this.

[atroche]

Thanks! I'm on master too, and it's working well. Any ETA on when anyone can cut a new release? This PR is depending on it: cljsjs/packages#273

But no rush =)

[twe4ked]

I've got a feeling this is waiting on #568.

[atroche]

@JedWatson any chance of a quick beta release, just so we can use this fix on a release?

[l4u]

@moggyboy The patch has been applied to v1.0.0-beta6 only. If you use 0.9.x, you've to edit that ReactDOM line. Which version are you using?

[michaelwebb76]

@l4u Thank you - I noticed you'd already answered above and so I deleted my comment.