Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting value before options available doesn't update placeholder #74

Closed
farism opened this issue Feb 26, 2015 · 3 comments
Closed

Setting value before options available doesn't update placeholder #74

farism opened this issue Feb 26, 2015 · 3 comments
Labels
issue/bug-confirmed Issues about a bug that has been confirmed by a maintainer
Milestone

Comments

@farism
Copy link

farism commented Feb 26, 2015

If you set the value on the component before the options are available (e.g. from a parent component's state, which got them from an async store), when the options are finally retrieved and the component is rerendered, the select placeholder stays stuck on the option value rather than displaying the option label. This doesn't seem to be an issue when using the async prop.

3 sec delay example:

http://jsfiddle.net/kb3gN/10048/

@farism
Copy link
Author

farism commented Mar 1, 2015

Submitted a PR to address this. I think the performance loss is fairly trivial.

#79

@dcousens
Copy link
Collaborator

dcousens commented May 7, 2015

Ref #53

@dcousens dcousens added the issue/bug-confirmed Issues about a bug that has been confirmed by a maintainer label May 7, 2015
@dcousens dcousens added this to the 0.4.9 milestone May 7, 2015
@dcousens dcousens self-assigned this May 7, 2015
@dcousens dcousens removed their assignment Aug 13, 2015
@dcousens
Copy link
Collaborator

Resolved after #79 was submitted.
ping @JedWatson to double check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue/bug-confirmed Issues about a bug that has been confirmed by a maintainer
Projects
None yet
Development

No branches or pull requests

2 participants