Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with unbiased residuals and KF tracks #986

Open
pbutti opened this issue Apr 28, 2023 · 0 comments
Open

Issue with unbiased residuals and KF tracks #986

pbutti opened this issue Apr 28, 2023 · 0 comments

Comments

@pbutti
Copy link
Contributor

pbutti commented Apr 28, 2023

Seems like there is a mismatch between unbiased-biased residuals lists when filling the unbiased residuals histograms.
The code was originally written for ST + GBL assuming 3D hits (axial-stereo pair always present). In the case where one of the two sides is missing, there might be an issue with filling the plots.
My guess is that this loop is poorly defined for scatterOnly planes
https://github.com/JeffersonLab/hps-java/blob/master/tracking/src/main/java/org/hps/recon/tracking/gbl/SimpleGBLTrajAliDriver.java#L959
sensorMap will be filled for scatter only planes as well, but the nmeas will be 0. Hence will be skipped in filling the vector for biased residuals. I was expecting to skip the filling on the b_residual vector, but I might be wrong. We could test this in 13hits tracks.
@cbravo135 @tomeichlersmith @sarahgaiser

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant