Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error handler ignores the field node when parsing the error message #378

Closed
Jericho opened this issue Nov 9, 2024 · 1 comment
Closed
Labels
Enhancement New feature or request
Milestone

Comments

@Jericho
Copy link
Owner

Jericho commented Nov 9, 2024

Consider an error message similar to this (notice the "field" node):

{
    "code":400, 
    "message":"Validation error. Check 'errors' field for details.",
    "errors":
    [
        {
            "field":"hub_id",
            "message":"must not be null"
        }
    ]
}

Currently, our error handler throws an exception with the following error message:
image

Notice the value contained in the field node is ignored which results in a vague error message. It would be much better if the error message was something along these lines:

hub_id must not be null
@Jericho Jericho added the Enhancement New feature or request label Nov 9, 2024
@Jericho Jericho added this to the 0.84.0 milestone Nov 9, 2024
@Jericho Jericho changed the title Error handler ignored the field node when parsing the error message Error handler ignores the field node when parsing the error message Nov 9, 2024
@Jericho
Copy link
Owner Author

Jericho commented Nov 15, 2024

🎉 This issue has been resolved in version 0.84.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant