Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing Screen Layout does not immediately change #133

Closed
5 of 11 tasks
DarkSide1305 opened this issue Dec 28, 2023 · 8 comments
Closed
5 of 11 tasks

Changing Screen Layout does not immediately change #133

DarkSide1305 opened this issue Dec 28, 2023 · 8 comments
Labels
bug Something isn't working screen layouts For issues involving the position of the emulated console's screens.

Comments

@DarkSide1305
Copy link

What version of melonDS DS are you using?

0.7.27

Does the problem happen in standalone melonDS?

I don't know.

What happened?

When you change the Screen Layout (from Top/Bottom to Rotated Left for example), the image is stuck in the resolution of the previous setting. So when you set it from Top/Bottom to Rotated Left, its squeezed into the area of Top/Bottom (
20231228_131830 ). Only upon a restart does it change to a proper aspect Ratio (
20231228_132028 ).

What should've happened instead?

The Aspect ratio should change immediately upon changing, for games that require spontaneous change like the Big Bowser Fights in Bowser's Inside Story.

Which platforms do you see the problem on?

  • Windows
  • macOS
  • Linux
  • Android
  • iOS
  • tvOS
  • Other (specify below)

Which versions of the OS?

SteamOS 3.5 (or the newest version currently available)

Which libretro frontend are you using?

RetroArch 1.16.0 (newest Flatpak)

Terms

  • I agree to follow the code of conduct.
  • I understand that melonDS DS is not developed or maintained by the authors of melonDS.
  • I understand that this form is for reporting bugs, not for requesting help.
  • I understand that the author develops this core in his spare time, and that he is under no obligation to respond to this bug report.
@DarkSide1305 DarkSide1305 added the bug Something isn't working label Dec 28, 2023
@JesseTG
Copy link
Owner

JesseTG commented Dec 29, 2023

Could you post a log of you reproducing the issue?

@DarkSide1305
Copy link
Author

retroarch__2023_12_29__15_34_01.log

This is a Log going from "Rotated Left" to "Top/Bottom", where the screen doesnt immediately update to be non-stretched.

@JesseTG
Copy link
Owner

JesseTG commented Dec 29, 2023

I cannot reproduce this issue on my Steam Deck, at least not with my build of RetroArch. I'll try this with the Flatpak release next. I wonder if this is a RetroArch bug that was fixed recently?

@JesseTG
Copy link
Owner

JesseTG commented Dec 29, 2023

I cannot reproduce this in the Flatpak build either. Could you try the latest release and see if the issue persists there? That release updated some relevant dependencies, including the one I use for the screen layout's math.

@DarkSide1305
Copy link
Author

I will give it a try, I have not tried the newest Release yes as nothing seemed to fix the issue, but maybe somehow its fixed.

@DarkSide1305
Copy link
Author

Nope, it has the exact issue. Let me record a video for you so I can show it.

@DarkSide1305
Copy link
Author

https://youtu.be/fqwz3smCwvk

In this video you can see how when I change the Screen Layout, it does not set to the new layout until I give RetroArch a restart. At the end you could also see me click "Close Content" which did nothing (#134), as you can see me cursoring around in the Menu but not in RetroArch.

@JesseTG
Copy link
Owner

JesseTG commented Dec 29, 2023

Ah ha! There we go. I have reproduced this bug successfully. I initially misunderstood the steps you were taking; I thought you were just pressing the "Next Screen Layout" button, which is what I had been doing. You were adjusting the current layout in the core options menu. I expect that most people will change the current layout with the Next Screen Layout button, but changing it directly in the options menu is supposed to work.

Thank you for the video and for the bug report. They were both helpful.

@JesseTG JesseTG closed this as completed in 8554bee Jan 2, 2024
@JesseTG JesseTG added the screen layouts For issues involving the position of the emulated console's screens. label Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working screen layouts For issues involving the position of the emulated console's screens.
Projects
None yet
Development

No branches or pull requests

2 participants