Explicitly specify constraint name in create table statement #570
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposed uses
ALTER TABLE
statements to create constraints in case when there are cycles in table structure. In this case it explicitly sets constraint name tofk_${fromCol.table.tableName}_${fromCol.name}_${targetColumn.name}
. However, if there are no cycles, constraints are defined inCREATE TABLE
statements without name specification: thus, their names are generated by database engine that uses different naming convention (ieTable_ibfk_1
in innodb).This patch makes Exposed to explicitly specify constraint names in
CREATE TABLE
statements.It also sets
identifierLengthLimit
for MySQL to 64 (as specified here) to fix test that fails otherwise.