Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable the use of binary type without length in oracle and postgresql… #716

Merged
merged 2 commits into from
Dec 17, 2019
Merged

Enable the use of binary type without length in oracle and postgresql… #716

merged 2 commits into from
Dec 17, 2019

Conversation

hfazai
Copy link
Contributor

@hfazai hfazai commented Dec 6, 2019

This pull request is related to the issue #618.
In oracle and postgresql, the binary column type doesn't require a length property. So this PR aims to allow declaring a binary column with/without specifying the length.
There are two scenarios :

  • using oracle or postgresql and specifying a length => warning is logged indicating that the length is not required and the program continues without error.
  • using other DB without specifying a length => error is logged indicating that the length is missing and the program fails with exception.

Tapac
Tapac reviewed Dec 15, 2019
View reviewed changes
Copy link
Contributor

@Tapac Tapac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you kindly add the list of dialects that support one or another binary functions into kdoc to help users select the proper one?

@Tapac Tapac merged commit e636a44 into JetBrains:master Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tapac Tapac Tapac left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hfazai @Tapac