Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diacritics on arbitrary characters not supported #100

Closed
hvdijk opened this issue Jan 27, 2020 · 1 comment
Closed

Diacritics on arbitrary characters not supported #100

hvdijk opened this issue Jan 27, 2020 · 1 comment
Labels
enhancement New feature or request unicode request Request for adding more symbols

Comments

@hvdijk
Copy link

hvdijk commented Jan 27, 2020

This report is based on how JetBrains Mono appears in Visual Studio Code.

When Unicode combining diacritical marks are used to place accents on arbitrary letters, unless the letter+accent is a known combination, the accent gets rendered as a box, and the letter gets rendered as non-monospaced. It should be fine to have a sub-optimal fallback for combinations not previously considered, as long as the result has the same width as all other characters and it is possible to make out which character it is supposed to be, but what happens now messes up the alignment and it is not possible to see which accent was intended.

This comes up in at least , which can be used in Dutch for emphasis, such as in "Dat is van míj́!"

This admittedly has very limited support in many other fonts as well, and even gets displayed wrong in my browser window here, but one very notable font where it does work almost perfectly is Fira Code. This is an issue when considering JetBrains Mono as a replacement for that.

@philippnurullin philippnurullin added the enhancement New feature or request label Jan 27, 2020
@philippnurullin philippnurullin added the unicode request Request for adding more symbols label Mar 16, 2020
@philippnurullin
Copy link
Member

Fixed in 2.300

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request unicode request Request for adding more symbols
Projects
None yet
Development

No branches or pull requests

2 participants