Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Powerline arrows aren't as large as the text bounding box #395

Closed
noahadvs opened this issue Jan 17, 2021 · 7 comments
Closed

Powerline arrows aren't as large as the text bounding box #395

noahadvs opened this issue Jan 17, 2021 · 7 comments
Milestone

Comments

@noahadvs
Copy link

noahadvs commented Jan 17, 2021

Powerline arrows aren't as large as the text bounding box. This causes odd seams and extra space above the top and below the bottom of Powerline arrow characters.

JetBrains Mono 10pts:

Screenshot_20210117_154547

Hack 10pts (no seams or extra space above and below arrows):

Screenshot_20210117_155314

Raw string:

  ✗ 

Starship prompt configuration:

[character]
format = "[ ](fg:white bg:black)$symbol "
success_symbol = "[](fg:black)"
error_symbol = "[](fg:black bg:red)[ ✗ ](bg:red)[](fg:red)"

System info

Operating System: openSUSE Tumbleweed 20210114

Application: Konsole (version 21.03.70, git master)

Qt Version: 5.15.2

FreeType version: 2.10.4

FreeType settings: antialiasing, slight hinting, RGB sub-pixel rendering

Screen resolution: 1920x1080

Scale factor: 1x

@philippnurullin
Copy link
Member

Hi @noahadvs Yes, this is definitely can be improved. Thanks for the feedback.

@philippnurullin philippnurullin added this to the v2.300 milestone Jan 18, 2021
philippnurullin added a commit that referenced this issue Jan 22, 2021
- Added exclusion in -> ligature to look reasonable in negative arguments for C++ <1-> #107
- /** brought back #202
- */ /* aligned to match *  #215
- Added multiline bracket characters ⎛ ⎞ ⎝ ⎠ ⎜ #290
- Fixed Powerline arrows height #395
@philippnurullin
Copy link
Member

Pelase grab files from here https://github.com/JetBrains/JetBrainsMono/tree/master/fonts to confirm positive change.

@noahadvs
Copy link
Author

noahadvs commented Jan 22, 2021

The height is much better now, but there is still a seam along the left side of the arrow:

Screenshot_20210122_112234

philippnurullin added a commit that referenced this issue Jan 25, 2021
- Added exclusion in `<-` ligature to look reasonable in negative arguments for C++ `<-1>` #107
- Removed `[||]` ligature to more consistence with `[|`  `|]` #353
- Added `ϖ` #369
- Added exclusion in `[<` `>]` to perform in `[<=5]` expression #388
- Fixed Powerline overlapping #395
@philippnurullin
Copy link
Member

Please test with latest update in master https://github.com/JetBrains/JetBrainsMono/tree/master/fonts

@noahadvs
Copy link
Author

It still has the seam:

Screenshot_20210125_140445

Just to be sure I'm updating correctly, here's what I did:

cd ~/src/JetBrains/JetBrainsMono/fonts/ttf/
git pull
sudo cp -t /usr/share/fonts/truetype/ ./*
fc-cache -f -v

Then I restarted every app that was using JetBrains Mono

philippnurullin added a commit that referenced this issue Jan 27, 2021
- Modified arrow symbols in Powerline set to remove gaps #395
@philippnurullin
Copy link
Member

Made more modifications in the latest release → https://github.com/JetBrains/JetBrainsMono/releases/tag/v2.225. If this not change the result to expected, please make another issue dedicated to the gap and we will continue to look for a solution.
Closing this issue because the original problem is solved.

@noahadvs
Copy link
Author

The seam problem is fixed now too, so no need for me to make a new issue. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants