Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chars ~ and @ look weird when used together #415

Closed
plagov opened this issue Feb 22, 2021 · 10 comments
Closed

Chars ~ and @ look weird when used together #415

plagov opened this issue Feb 22, 2021 · 10 comments

Comments

@plagov
Copy link

plagov commented Feb 22, 2021

First of all, thanks a lot for the great font! I started using it the same day JetBrains has announced it.

The issue I have encountered.

When using chars ~ followed by @, then they look a bit weird. For example, the string: ~@clean-up:
image

@yvvt0379
Copy link

I suggest these two characters remain how they originally look but be connected together.

@exorcist365
Copy link
Contributor

This is a ligature and not a bug.

@Xerrion
Copy link

Xerrion commented Mar 11, 2021

This is a ligature and not a bug.

He didn't call it a bug.

@yvvt0379
Copy link

yvvt0379 commented Mar 26, 2021 via email

@philippnurullin
Copy link
Member

@plagov Thanks for the feedback! I'll see how this can be improved.

@yvvt0379
Copy link

yvvt0379 commented Jul 2, 2021

@philippnurullin I came up with an idea, just like this:
无标题
Would it be better?

@philippnurullin
Copy link
Member

@CodeCrazy-ywt Interesting suggestion!
Need to test it in the small size. I'm worrying that the ˜ won't be recognizieble. But maybe it's ok like this.

@Xerrion
Copy link

Xerrion commented Jul 2, 2021

@CodeCrazy-ywt Interesting suggestion!
Need to test it in the small size. I'm worrying that the ˜ won't be recognizieble. But maybe it's ok like this.

I think this is way more recognisable than the current one, where the @ symbol just looks like a weird a trailing of. Also why would ~ be superscripted here.

philippnurullin added a commit that referenced this issue Jul 14, 2021
- Added Control code support #241
- Update all # dependent glyphs #275
- Added Ɛ ↋ ↊ ૪ #356
- Changed the look of ~@ ligature #415
- Added EMQuad (u+2001) #439
- The tail of Italic “f” made shorter #441
- Reworked ⚠️ #450
- Added SemiBold weight #453
- Added more anchors to the marks #463
- Added replacement (u+FFFD) #461
- Added zeroWidthNoBreakSpace (u+FEFF) #467
- Fixed consistent of J in italic
@philippnurullin
Copy link
Member

Changed the construction of ~@ in the latest commit. Please test.
You can grab files from here https://github.com/JetBrains/JetBrainsMono/tree/master/fonts

@yvvt0379
Copy link

Looks much better than before. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants