Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The lowercase f in italic slightly overlaps with other italic charaters #441

Closed
minhduc0711 opened this issue May 17, 2021 · 4 comments
Closed

Comments

@minhduc0711
Copy link

This causes a problem in kitty terminal emulator (kovidgoyal/kitty#3630) because it only renders what is inside a character cell.
I wonder if it is possible to shorten the top/bottom hook of the italic f, to make its width consistent with other italic characters?

image

@philippnurullin
Copy link
Member

Hi @minhduc0711 There is about 300 glyph in italic that have negative value of left side bearing. For example all the BoxDrawing elements happen to have the LSB equal to -20 so they maintain the correct position.

The problem as is see it that the kitty terminal is modifying the original spacing in the font. I'm sure they have reasons for it, but it is still not showing the font how it was designed.

I will see what can be tweaked in f and dependent symbols. It must solve most common problems but not sure it will solve all the potential problems.

@kovidgoyal
Copy link

You dont need to fix box drawing symbols, kitty will draw them itself, not from the font. Just letter shapes in all variants of a monospace font need to fit within the same bounding box and not bleed into neighboring characters, as kitty draws all characters independently, in parallel, for performance reasons.

philippnurullin added a commit that referenced this issue Jul 14, 2021
- Added Control code support #241
- Update all # dependent glyphs #275
- Added Ɛ ↋ ↊ ૪ #356
- Changed the look of ~@ ligature #415
- Added EMQuad (u+2001) #439
- The tail of Italic “f” made shorter #441
- Reworked ⚠️ #450
- Added SemiBold weight #453
- Added more anchors to the marks #463
- Added replacement (u+FFFD) #461
- Added zeroWidthNoBreakSpace (u+FEFF) #467
- Fixed consistent of J in italic
@philippnurullin
Copy link
Member

Changed the italic f.
Please test with the files from here https://github.com/JetBrains/JetBrainsMono/tree/master/fonts

@minhduc0711
Copy link
Author

Thank you, looks great now 🙌
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants