Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emoji ⚠️ is not shown as emoji #450

Closed
muuvmuuv opened this issue May 27, 2021 · 13 comments
Closed

Emoji ⚠️ is not shown as emoji #450

muuvmuuv opened this issue May 27, 2021 · 13 comments

Comments

@muuvmuuv
Copy link

Using the Emoji "⚠️" in VS Code just displays a Unicode Symbol, even with a fallback font:

Bildschirmfoto 2021-05-27 um 14 03 32

I am aware that there was a previous discussion about monospaced fonts should not include Emoji support, but then why is this happening, and how can I prevent it?

@philippnurullin
Copy link
Member

Hi @muuvmuuv It's happening because we added a ⚠️ symbol in the JB Mono.

To prevent it from happening you need to modify the font files. Delete the warningSign Uni-26A0.
Ideally you need to have Glyphs app, so you can edit the source and build from it using scripts provided in Sources repository.

But here is a link to StackOverflow with other options https://stackoverflow.com/questions/12976424/how-to-remove-characters-from-a-font-file

@philippnurullin
Copy link
Member

What is the advantage of using this Emoji?
Maybe the glyph in JB Mono can be modified to match these criteria.

@muuvmuuv
Copy link
Author

It isn't that mandatory for me so that I am willed to spend the time on modifying the font, but thanks for the hint, good reading!

The advantage for me and other project members would be that the yellowish Emoji stand out much more than the grey symbol.

philippnurullin added a commit that referenced this issue Jul 14, 2021
- Added Control code support #241
- Update all # dependent glyphs #275
- Added Ɛ ↋ ↊ ૪ #356
- Changed the look of ~@ ligature #415
- Added EMQuad (u+2001) #439
- The tail of Italic “f” made shorter #441
- Reworked ⚠️ #450
- Added SemiBold weight #453
- Added more anchors to the marks #463
- Added replacement (u+FFFD) #461
- Added zeroWidthNoBreakSpace (u+FEFF) #467
- Fixed consistent of J in italic
@philippnurullin
Copy link
Member

Increased the size of ⚠️as possible and made it black so it pop out more.
You can grab the files from here https://github.com/JetBrains/JetBrainsMono/tree/master/fonts

@fpopineau
Copy link

Hi,
Isn't that a bit strange to make this emoji black? I thought that the whole purpose of these emojis is to stand out with their classic (flashy) colors?
Regards and thanks for the JetBrains fonts.

@alexeyten
Copy link
Contributor

@fpopineau there is a good article about emoji https://tonsky.me/blog/emoji/

Especially see Variation selector-16 part

@fpopineau
Copy link

fpopineau commented Jul 30, 2022 via email

@alexeyten
Copy link
Contributor

I'm pretty sure it works on Windows, but it may not work in some applications.

@fpopineau
Copy link

fpopineau commented Jul 31, 2022 via email

@alexeyten
Copy link
Contributor

@fpopineau images in your answer are missing. Please answer from github website.

@fpopineau
Copy link

@fpopineau images in your answer are missing. Please answer from github website.

Sorry. I have edited the message above.

@alexeyten
Copy link
Contributor

Looks like Chromium-based browsers have a bug https://bugs.chromium.org/p/chromium/issues/detail?id=964527

Firefox
Firefox screenshot

Chromium-based Browser
Chromium-based Browser screenshot

Test page

@KotlinIsland
Copy link

The latest EAP supports variation selector 15/16 for emoji characters. https://youtrack.jetbrains.com/issue/JBR-4832/Support-Variation-Selectors-in-text-rendering-for-emojies

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants