Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Characters with more vertical content (e.g "f") overlap with overhead bar #463

Closed
darsnack opened this issue Jun 23, 2021 · 10 comments
Closed
Labels
enhancement New feature or request

Comments

@darsnack
Copy link

See the screenshot below. Certain characters when combined with an overhead bar look like they are overlapping with the bar. This is especially hard to read for cases like "f" or "t" where it becomes difficult to see what overhead character is used at a glance.
Screen Shot 2021-06-23 at 9 38 41 AM

For example, the following are "f" + "bar" and "f" + "hat/carrot".
Screen Shot 2021-06-23 at 9 39 32 AM

Sorry that I am not familiar with the Unicode numbers off the top of my head.

@philippnurullin
Copy link
Member

Hi @darsnack . Please copy and paste the letters. This will be a great help.
In what language they are used?

@darsnack
Copy link
Author

I use these characters in Julia, and I created them using the Julia REPL. I pasted the characters and the sequence I typed into the REPL to generate them below

The first screenshot:

x̄ȳāj̄f̄h̄t̄

julia> x\bar[TAB] y\bar[TAB] a\bar[TAB] j\bar[TAB] f\bar[TAB] h\bar[TAB] t\bar[TAB]

The second screenshot:

f̄f̂

julia> f\bar[TAB] f\hat[TAB]

@philippnurullin
Copy link
Member

I see what the problem is. Will fix this in the one of the next updates.

@philippnurullin philippnurullin added the enhancement New feature or request label Jun 23, 2021
philippnurullin added a commit that referenced this issue Jul 14, 2021
- Added Control code support #241
- Update all # dependent glyphs #275
- Added Ɛ ↋ ↊ ૪ #356
- Changed the look of ~@ ligature #415
- Added EMQuad (u+2001) #439
- The tail of Italic “f” made shorter #441
- Reworked ⚠️ #450
- Added SemiBold weight #453
- Added more anchors to the marks #463
- Added replacement (u+FFFD) #461
- Added zeroWidthNoBreakSpace (u+FEFF) #467
- Fixed consistent of J in italic
@philippnurullin
Copy link
Member

Hi, please grab files from here https://github.com/JetBrains/JetBrainsMono/tree/master/fonts and confirm/deny postive change. Thanks in advance!

@darsnack
Copy link
Author

I don't think it has changed:
Screen Shot 2021-07-15 at 4 01 38 PM

Screen Shot 2021-07-15 at 4 03 11 PM

@darsnack
Copy link
Author

It looks okay in iTerm, but not VS Code.

Screen Shot 2021-07-15 at 4 43 10 PM

@philippnurullin
Copy link
Member

Ok, thanks for the feedback I will continue to work on that

philippnurullin added a commit that referenced this issue Jul 20, 2021
- Remapped Control codes unicode numbers #241
- Added ǒ ǐ ǔ ǖ ǘ ǚ ǜ #187
- Added even more anchors #463
@philippnurullin
Copy link
Member

Please test again.

@darsnack
Copy link
Author

Sorry for the delay. Just tested again, and it looks good. Thanks for your work!

@philippnurullin
Copy link
Member

No worries. I was pretty confident this time .))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants