Deprecate Modifier.mouseClickable. It should be replaced by Modifier.onClick #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igordmn
approved these changes
Jun 20, 2022
eymar
added a commit
that referenced
this pull request
Jun 27, 2022
…onClick (#243) Co-authored-by: Oleksandr Karpovich <oleksandr.karpovich@jetbrains.com>
eymar
added a commit
that referenced
this pull request
Jun 28, 2022
…onClick (#243) Co-authored-by: Oleksandr Karpovich <oleksandr.karpovich@jetbrains.com>
igordmn
pushed a commit
that referenced
this pull request
Aug 18, 2022
…onClick (#243) Co-authored-by: Oleksandr Karpovich <oleksandr.karpovich@jetbrains.com>
igordmn
pushed a commit
that referenced
this pull request
Aug 18, 2022
…onClick (#243) Co-authored-by: Oleksandr Karpovich <oleksandr.karpovich@jetbrains.com>
eymar
added a commit
that referenced
this pull request
Oct 26, 2022
…onClick (#243) Co-authored-by: Oleksandr Karpovich <oleksandr.karpovich@jetbrains.com>
eymar
added a commit
that referenced
this pull request
Nov 16, 2022
…onClick (#243) Co-authored-by: Oleksandr Karpovich <oleksandr.karpovich@jetbrains.com>
eymar
added a commit
that referenced
this pull request
Jan 13, 2023
…onClick (#243) Co-authored-by: Oleksandr Karpovich <oleksandr.karpovich@jetbrains.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Questions:
Currently, the replaceWith expression ignores
onClickLabelandrolearguments.We can try to add
role-semantics(true) { if (role != null) this.role = role }. But it ends up with weird and verbose construction whenrolevalue is default (null).I think that we can't set
onClickLabelon behalf of a user, becauseonClickLabelmakes sense only for Primary click, andonClickcan be added multiple times with different click handlers.Also, mouseClickable adds
detectClickFromKey,indication,hoverable,focusableInNonTouchMode, which are not added withinonClickand not added by replaceWith expression. I think the most convenient option is to describe these nuances in the tutorial.