In placeAutoMirrored for RTL, calculate the placement position using the placeable width respecting the constraints #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the placeable width respecting the constraints It used to calculate the position using `measuredSize.width` which doesn't respect the constraints, and therefore the position could end up outside of the parent's bounds. Test: run ui and foundation-layout tests, added an additional demo to RtlDemo Change-Id: I946079669ef6ad783708d9f958dd4231188451c5
igordmn
pushed a commit
that referenced
this pull request
Aug 18, 2022
…the placeable width respecting the constraints (#267) It used to calculate the position using `measuredSize.width` which doesn't respect the constraints, and therefore the position could end up outside of the parent's bounds. Test: run ui and foundation-layout tests, added an additional demo to RtlDemo Change-Id: I946079669ef6ad783708d9f958dd4231188451c5 Co-authored-by: Oleksandr Karpovich <oleksandr.karpovich@jetbrains.com>
igordmn
pushed a commit
that referenced
this pull request
Aug 18, 2022
…the placeable width respecting the constraints (#267) It used to calculate the position using `measuredSize.width` which doesn't respect the constraints, and therefore the position could end up outside of the parent's bounds. Test: run ui and foundation-layout tests, added an additional demo to RtlDemo Change-Id: I946079669ef6ad783708d9f958dd4231188451c5 Co-authored-by: Oleksandr Karpovich <oleksandr.karpovich@jetbrains.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It used to calculate the position using
measuredSize.widthwhich doesn't respect the constraints, and therefore the position could end up outside of the parent's bounds.Test: run ui and foundation-layout tests, added an additional demo to RtlDemo
Change-Id: I946079669ef6ad783708d9f958dd4231188451c5
Cherry-picked from CL:
https://android-review.googlesource.com/c/platform/frameworks/support/+/2172328