Show new window/dialog on the same display #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tested manually on Windows/macOs/Linux with two displays. Tested the case when we disconnect one display. The new behaviour of opening windows is different from platform default. Windows/macOS, for example, shows every new window slighly shifted in compare to the previous opened window. We on the other hand shift in compare to the previous focused window, not the opened. RelNote: Changed behaviour of the initial position of the new window. Now it shows on the display, where was the latest focused window Fixes JetBrains/compose-multiplatform#1845
igordmn
changed the title
eymar
reviewed
Oct 4, 2022
compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/window/Dialog.desktop.kt
Outdated
Show resolved
Hide resolved
eymar
reviewed
Oct 4, 2022
...ose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/window/WindowLocationTracker.desktop.kt
Show resolved
Hide resolved
eymar
approved these changes
Oct 4, 2022
eymar
pushed a commit
that referenced
this pull request
Oct 26, 2022
* Show new window/dialog on the same display. Tested manually on Windows/macOs/Linux with two displays. Tested the case when we disconnect one display. The new behaviour of opening windows is different from platform default. Windows/macOS, for example, shows every new window slighly shifted in compare to the previous opened window. We on the other hand shift in compare to the previous focused window, not the opened. RelNote: Changed behaviour of the initial position of the new window. Now it shows on the display, where was the latest focused window Fixes JetBrains/compose-multiplatform#1845 * Don't compute platformDefaultPosition every time when we change the position
eymar
pushed a commit
that referenced
this pull request
Nov 16, 2022
* Show new window/dialog on the same display. Tested manually on Windows/macOs/Linux with two displays. Tested the case when we disconnect one display. The new behaviour of opening windows is different from platform default. Windows/macOS, for example, shows every new window slighly shifted in compare to the previous opened window. We on the other hand shift in compare to the previous focused window, not the opened. RelNote: Changed behaviour of the initial position of the new window. Now it shows on the display, where was the latest focused window Fixes JetBrains/compose-multiplatform#1845 * Don't compute platformDefaultPosition every time when we change the position
eymar
pushed a commit
that referenced
this pull request
Jan 13, 2023
* Show new window/dialog on the same display. Tested manually on Windows/macOs/Linux with two displays. Tested the case when we disconnect one display. The new behaviour of opening windows is different from platform default. Windows/macOS, for example, shows every new window slighly shifted in compare to the previous opened window. We on the other hand shift in compare to the previous focused window, not the opened. RelNote: Changed behaviour of the initial position of the new window. Now it shows on the display, where was the latest focused window Fixes JetBrains/compose-multiplatform#1845 * Don't compute platformDefaultPosition every time when we change the position
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested manually on Windows/macOs/Linux with two displays. Tested the case when we disconnect one display.
The new behaviour of opening windows is different from platform default. Windows/macOS, for example, shows every new window slighly shifted in compare to the previous opened window. We on the other hand shift in compare to the previous focused window, not the opened.
RelNote:
Changed behaviour of the initial position of the new window. Now it shows on the display, where was the latest focused window
Fixes JetBrains/compose-multiplatform#1845