Allow customizing Compose compiler plugin #2347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, the Compose Multiplatform Gradle plugin uses `org.jetbrains.compose.compiler:compiler:<COMPOSE_VERSION>` as a compiler plugin . However, a new version of Kotlin might be incompatible with the default version of compiler plugin. Previously, that forced users to update to a new version of Compose Gradle plugin & Compose libraries in order to use a new version of Kotlin. Accordingly, Compose framework developers had to release a new version of all libraries, when a new version of Kotlin is released. Some time ago the Compose team at Google made it possible to update a compiler plugin without updating the Gradle plugin and/or all Compose libraries https://developer.android.com/jetpack/androidx/releases/compose-kotlin This change allows to specify a custom compiler artifact by using the following DSL: ``` compose { kotlinCompilerPlugin.set("<VERSION<") // or kotlinCompilerPlugin.set("<GROUP_ID>:<ARTIFACT_ID>:<VERSION>") } ```
Can we use a property? It is more idiomatic for Gradle Kotlin DSL: |
|
@igordmn I'm not sure. Gradle seems to be moving in direction of switching to Provider API everywhere in Gradle 9. Also they are going to add an assignment operator overload to |
We should also prepare a page with tutorial how to to that in with mapping table. Also, worth to add our own exception in Gradle plugin with a link to that page. |
Ok, let's keep the current way |
dima-avdeev-jb
approved these changes
Sep 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, the Compose Multiplatform Gradle plugin uses
org.jetbrains.compose.compiler:compiler:<COMPOSE_VERSION>as a compiler plugin .However, a new version of Kotlin might be incompatible with the default version of compiler plugin. Previously, that forced users to update to a new version of Compose Gradle plugin & Compose libraries in order to use a new version of Kotlin. Accordingly, Compose framework developers had to release a new version of all libraries, when a new version of Kotlin is released.
Some time ago the Compose team at Google made it possible to update a compiler plugin without updating the Gradle plugin and/or all Compose libraries https://developer.android.com/jetpack/androidx/releases/compose-kotlin
This change allows to specify a custom compiler artifact by using the following DSL: