CSS Unit Refactoring #761
Closed
CSS Unit Refactoring #761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lue, CSSResolutionValue, CSSFlexValue are marker interfaces
I'm not sure we need them though at all
eymar
reviewed
Jun 7, 2021
| @@ -7,18 +7,18 @@ object AppCSSVariables : CSSVariables { | |||
| val wtColorGreyLight by variable<Color>() | |||
| val wtColorGreyDark by variable<Color>() | |||
|
|
|||
| val wtOffsetTopUnit by variable<CSSSizeValue>() | |||
There was a problem hiding this comment.
This change leads to breaking the web_landing example if it's built using published artifact, doesn't it?
I don't think it's critical. Anyway it will need to get updated very soon after release.
There was a problem hiding this comment.
I think it's safe enough to swap names for CSSUnit and CSSSize -> in that case anything won't change in that aspect.
Will try after all comments on this PR will be collected )
eymar
reviewed
Jun 7, 2021
| @@ -87,7 +87,7 @@ interface CSSNumberish { | |||
| } | |||
|
|
|||
| fun CSSNumberish.asNumber() = this.asDynamic() as? Number | |||
| fun CSSNumberish.asCSSNumericValue(): CSSNumericValue? = this.asDynamic() as? CSSNumericValueJS | |||
| fun CSSNumberish.asCSSNumericValue(): CSSNumericValue? = this.asDynamic() as? CSSNumericValue | |||
There was a problem hiding this comment.
I'm asking this without having a broader context in mind, but I'm just curious if it can be not nullable?
fun CSSNumberish.asCSSNumericValue(): CSSNumericValue = this.asDynamic() as CSSNumericValue
or
fun CSSNumberish.asCSSNumericValue(): CSSNumericValue = this.asDynamic().unsafeCast<CSSNumericValue>()
There was a problem hiding this comment.
I really see no reason why it can not so let me check!
eymar
reviewed
Jun 7, 2021
web/core/src/jsMain/kotlin/androidx/compose/web/css/CSSUnits.kt
Outdated
Show resolved
Hide resolved
eymar
approved these changes
Jun 7, 2021
|
I promise, I promise, I will use the green button! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part one of what's needed to move forward with two (related but different) tasks: