Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compose Multiplatform should warn when CADisableMinimumFrameDurationOnPhone is not configured properly #3634

Closed
SebastianAigner opened this issue Sep 6, 2023 · 1 comment · Fixed by JetBrains/compose-multiplatform-core#795
Assignees
Labels

Comments

@SebastianAigner
Copy link
Member

SebastianAigner commented Sep 6, 2023

Describe the bug
Projects created with our mobile template before this commit – or without our template – don't specify the correct value for CADisableMinimumFrameDurationOnPhone by default. This results in visibly degraded performance on high-refresh-rate displays, because it locks the UI to 60fps.

Compose should warn the user on app startup if this setting is misconfigured. Such a warning would hopefully help prevent folks accidentally publishing Compose Multiplatform apps that have degraded visual performance.

Affected platforms

  • iOS

Versions

  • Compose Multiplatform version*: 1.5
@SebastianAigner SebastianAigner added bug Something isn't working ios submitted labels Sep 6, 2023
@igordmn
Copy link
Collaborator

igordmn commented Sep 6, 2023

Sounds reasonable.

We probably should check it in Runtime, because we don't always have access to plist at compile time (in case if Compose added to the existing applciation without using our Gradle plugin in the app module)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants