Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make PRODUCTS_RELEASES_ANDROID_STUDIO and PRODUCTS_RELEASES_JETBRAINS_IDES configurable #1686

Closed
mr-thierry opened this issue Jul 9, 2024 · 3 comments
Assignees
Labels
Milestone

Comments

@mr-thierry
Copy link

What happened?

Using 2.0.0-beta8, these URLs cannot be configured. We build our plugins on an internal CI server which cannot access the URL. We maintain an internal proxy to these files. But with 2.0.0-beta8 it is not possible to configure a different URL.

Relevant log output or stack trace

No response

Steps to reproduce

  1. Create a plugin
  2. Build the plugin on a server that cannot access https://www.jetbrains.com/updates/updates.xml
  3. The build will fail

Gradle IntelliJ Plugin version

2.0.0-beta8

Gradle version

8.8

Operating System

None

Link to build, i.e. failing GitHub Action job

No response

@mr-thierry mr-thierry added the bug label Jul 9, 2024
@hsz hsz added this to the 2.0.0-beta9 milestone Jul 9, 2024
@hsz
Copy link
Member

hsz commented Jul 10, 2024

Thanks for highlighting that, Roy!
I did some refactoring around so-called Build Features and created a mechanism for accepting not only boolean values.
Having that, I could easily introduce Gradle properties for customizing mentioned URLs.

Starting from 2.0.0-beta9, you'll be able to set in gradle.properties file:

org.jetbrains.intellij.platform.productsReleasesAndroidStudioUrl=https://jb.gg/android-studio-releases-list.xml
org.jetbrains.intellij.platform.productsReleasesJetBrainsIdesUrl=https://www.jetbrains.com/updates/updates.xml

@hsz hsz closed this as completed Jul 10, 2024
@mr-thierry
Copy link
Author

Thanks for the fast follow-up!

That being said, wouldn't it make more sense to be part of the build config? i.e. in build.gradle.kts something like:

intellijPlatform {
   productsReleasesAndroidStudioUrl=https://jb.gg/android-studio-releases-list.xml
   productsReleasesJetBrainsIdesUrl=https://www.jetbrains.com/updates/updates.xml
}

@hsz
Copy link
Member

hsz commented Jul 11, 2024

I get your point, but one should not often adjust this. Also, the mechanism of resolving dependencies is pretty deep — that part is executed in dependencies resolution, and passing IntelliJ Platform extension properties down there would be tricky.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants