Fix Gradle plugin inputs validation issue

Also add '@internal' annotation in interface, so it propagated to all inheritors. ^KT-52448 Fixed
JetBrains · Jun 6, 2022 · ec73f40 · ec73f40
1 parent 5f3b1e3
commit ec73f40
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 0 deletions.
diff --git a/...radle-plugin-api/src/common/kotlin/org/jetbrains/kotlin/gradle/tasks/KotlinTaskConfigs.kt b/...radle-plugin-api/src/common/kotlin/org/jetbrains/kotlin/gradle/tasks/KotlinTaskConfigs.kt
@@ -43,6 +43,12 @@ interface KotlinCompileTool : PatternFilterable, Task {
 
     @get:OutputDirectory
     val destinationDirectory: DirectoryProperty
+
+    @Internal
+    override fun getExcludes(): MutableSet<String>
+
+    @Internal
+    override fun getIncludes(): MutableSet<String>
 }
 
 interface BaseKotlinCompile : KotlinCompileTool {

diff --git a/...gin-integration-tests/src/test/kotlin/org/jetbrains/kotlin/gradle/SimpleKotlinGradleIT.kt b/...gin-integration-tests/src/test/kotlin/org/jetbrains/kotlin/gradle/SimpleKotlinGradleIT.kt
@@ -226,4 +226,21 @@ class SimpleKotlinGradleIT : KGPBaseTest() {
             }
         }
     }
+
+    @DisplayName("Validate Gradle plugins inputs")
+    @GradleTestVersions(minVersion = TestVersions.Gradle.MAX_SUPPORTED) // Always should use only latest Gradle version
+    @GradleTest
+    internal fun validatePluginInputs(gradleVersion: GradleVersion) {
+        project("kotlinProject", gradleVersion) {
+            buildGradle.modify {
+                """
+                plugins {
+                    id "validate-external-gradle-plugin"
+                ${it.substringAfter("plugins {")}
+                """.trimIndent()
+            }
+
+            build("validateExternalPlugins")
+        }
+    }
 }