🚸 Improve user messaging about token and options

JetBrains · Sep 18, 2023 · 3a1393f · 3a1393f
1 parent 6a68d9d
commit 3a1393f
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 6 deletions.
diff --git a/cmd/scan.go b/cmd/scan.go
@@ -85,7 +85,7 @@ But you can always override qodana.yaml options with the following command-line
 			}
 			if exitCode == core.QodanaFailThresholdExitCode {
 				core.EmptyMessage()
-				core.ErrorMessage("The number of problems exceeds the failThreshold")
+				core.ErrorMessage("The number of problems exceeds the fail threshold")
 				os.Exit(exitCode)
 			}
 		},

diff --git a/core/options.go b/core/options.go
@@ -211,3 +211,7 @@ func (o *QodanaOptions) properties() (map[string]string, []string) {
 	}
 	return props, flagsArr
 }
+
+func (o *QodanaOptions) requiresToken() bool {
+	return (o.Linter != Image(QDPYC) && o.Linter != Image(QDJVMC)) || o.Ide != ""
+}
diff --git a/core/sarif.go b/core/sarif.go
@@ -67,10 +67,12 @@ func ReadSarif(sarifPath string, printProblems bool) {
 			}
 		}
 	}
-	if newProblems == 0 {
-		SuccessMessage("It seems all right 👌 No new problems found according to the checks applied")
-	} else {
-		ErrorMessage("Found %d new problems according to the checks applied", newProblems)
+	if !IsContainer() {
+		if newProblems == 0 {
+			SuccessMessage("It seems all right 👌 No new problems found according to the checks applied")
+		} else {
+			ErrorMessage("Found %d new problems according to the checks applied", newProblems)
+		}
 	}
 }
 

diff --git a/core/token.go b/core/token.go
@@ -86,7 +86,7 @@ func (o *QodanaOptions) getTokenFromKeychain(refresh bool) string {
 }
 
 func (o *QodanaOptions) getTokenFromUserInput() string {
-	if IsInteractive() {
+	if IsInteractive() && o.requiresToken() {
 		WarningMessage(cloud.EmptyTokenMessage)
 		var token string
 		for {