Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing TypeScript Definition for strictMode Option #1480

Open
Staninna opened this issue Nov 13, 2024 · 0 comments
Open

Missing TypeScript Definition for strictMode Option #1480

Staninna opened this issue Nov 13, 2024 · 0 comments
Labels
Milestone

Comments

@Staninna
Copy link

Issue Description

The strictMode option is currently implemented in SunEditor but lacks proper TypeScript type definitions in src/options.d.ts. This makes it difficult to use the option when working with TypeScript projects.

If I've overlooked something or if this type definition already exists somewhere else in the codebase, please let me know! I'm happy to be pointed in the right direction.

Current Behavior

  • strictMode option exists and is functional in the codebase
  • References to strictMode can be found in the source code and commit history
  • The option is missing from the TypeScript type definitions

Expected Behavior

The strictMode option should be properly defined in src/options.d.ts with appropriate TypeScript type definitions.

Related Code References

Proposed Solution

Add the strictMode type definition to src/options.d.ts:

interface SunEditorOptions {
  // ... existing options ...
  strictMode?: boolean;
}
@JiHong88 JiHong88 added the bug label Nov 26, 2024
@JiHong88 JiHong88 added this to the 2.47.1 milestone Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants