New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Balance in Dawid Skene is obsolete. #36

Open

ch-shin opened this issue Aug 9, 2022 · 1 comment

ch-shin commented Aug 9, 2022

wrench/wrench/labelmodel/dawid_skene.py

Line 55 in 6d83979

balance: Optional[np.ndarray] = None,

I realized this balance variable is used nowhere in this file. If it is intended, I think it should be removed from input parameters.

Author

ch-shin commented Aug 9, 2022

Actually the following three parameters are not used. - I think it could be better to remove them to prevent confusion?

dataset_valid: Optional[Union[BaseDataset, np.ndarray]] = None,
y_valid: Optional[np.ndarray] = None,
balance: Optional[np.ndarray] = None,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment