From d6d5be41ea8a572c96f76017182e9a3627897aad Mon Sep 17 00:00:00 2001
From: Christian Zentgraf <kitgocz@gmail.com>
Date: Tue, 12 Mar 2024 12:54:46 -0400
Subject: [PATCH] Update function signature

---
 velox/expression/SimpleFunctionAdapter.h |  2 ++
 velox/functions/CoverageUtil.h           | 10 ++++++++++
 2 files changed, 12 insertions(+)

diff --git a/velox/expression/SimpleFunctionAdapter.h b/velox/expression/SimpleFunctionAdapter.h
index 8c0bb54d5b12..62eae31478ab 100644
--- a/velox/expression/SimpleFunctionAdapter.h
+++ b/velox/expression/SimpleFunctionAdapter.h
@@ -968,6 +968,8 @@ class SimpleFunctionAdapterFactoryImpl : public SimpleFunctionAdapterFactory {
  public:
   // Exposed for use in FunctionRegistry
   using Metadata = typename UDFHolder::Metadata;
+  static constexpr bool isDefaultNullBehavior =
+      UDFHolder::is_default_null_behavior;
 
   explicit SimpleFunctionAdapterFactoryImpl() {}
 
diff --git a/velox/functions/CoverageUtil.h b/velox/functions/CoverageUtil.h
index 9c25a5478155..bf666101ba70 100644
--- a/velox/functions/CoverageUtil.h
+++ b/velox/functions/CoverageUtil.h
@@ -17,9 +17,19 @@
 
 #include <string>
 #include <unordered_set>
+#include <vector>
 
 namespace facebook::velox::functions {
 
+// Returns sorted list of scalar function names available in Velox.
+std::vector<std::string> getSortedScalarNames();
+
+// Returns sorted list of aggregate function names available in Velox.
+std::vector<std::string> getSortedAggregateNames();
+
+// Returns sorted list of window function names available in Velox.
+std::vector<std::string> getSortedWindowNames();
+
 // Print a rst format string which contains all Presto/Spark scalar
 // functions and aggragate functions. This function will read
 // all_scalar_functions.txt and all_aggregate_functions.txt from certain path.