diff --git a/velox/exec/trace/test/QueryTraceTest.cpp b/velox/exec/trace/test/QueryTraceTest.cpp index 8b969cc1b9b6..171c7cea138a 100644 --- a/velox/exec/trace/test/QueryTraceTest.cpp +++ b/velox/exec/trace/test/QueryTraceTest.cpp @@ -337,19 +337,21 @@ TEST_F(QueryTracerTest, traceDir) { fs->mkdir(parentDir); constexpr auto numThreads = 5; - std::vector queryThreads; - queryThreads.reserve(numThreads); + std::vector traceThreads; + traceThreads.reserve(numThreads); + std::mutex mutex; std::set expectedDirs; for (int i = 0; i < numThreads; ++i) { - queryThreads.emplace_back([&, i]() { + traceThreads.emplace_back([&, i]() { const auto dir = fmt::format("{}/s{}", parentDir, i); trace::createTraceDirectory(dir); + std::lock_guard l(mutex); expectedDirs.insert(dir); }); } - for (auto& queryThread : queryThreads) { - queryThread.join(); + for (auto& traceThread : traceThreads) { + traceThread.join(); } const auto actualDirs = fs->list(parentDir);