Remove shortpl from public API #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
avaldebe
commented
Jun 13, 2022
avaldebe
commented
- close Drop "pl"/"shortpl" terminology in favor of something more readable #26
- close Make search_pollutant and pollutants_per_country output consistent with all_pollutants #27
|
It is OK io I merge this PR into the v1.0 branch? Cheers, PS: |
|
Yes I think so. Let's put a deprecation warning in on master as well. Should probably have included that in 0.6, oh well 😄 we can finish the cleanup and then release an 0.7 that contains warnings. |
|
Good point, I'll create a separate PR with the deprecation warnings targeting the master branch and remove them from this PR. |
avaldebe
force-pushed
the
drop-shortpl
branch
from
f74b518
to
1ef8f2d
Compare
avaldebe
force-pushed
the
drop-shortpl
branch
from
1ef8f2d
to
0f911c8
Compare
|
Sorry this took so long to get to 😅 changes look solid! I'll merge this, and once #40 is merged I'll need to rebase this onto master as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.