From 72496d88d3b80ecc4d24e1fec84d399c8efa4466 Mon Sep 17 00:00:00 2001 From: Guillaume Gomez Date: Wed, 18 May 2022 11:39:46 +0200 Subject: [PATCH 1/2] Move some DOM generation into the HTML settings file directly --- src/librustdoc/html/render/context.rs | 16 +++++++++++++--- src/librustdoc/html/static/js/settings.js | 18 ++---------------- 2 files changed, 15 insertions(+), 19 deletions(-) diff --git a/src/librustdoc/html/render/context.rs b/src/librustdoc/html/render/context.rs index 528180288de6a..81f961992b6f1 100644 --- a/src/librustdoc/html/render/context.rs +++ b/src/librustdoc/html/render/context.rs @@ -596,9 +596,19 @@ impl<'tcx> FormatRenderer<'tcx> for Context<'tcx> { |buf: &mut Buffer| { write!( buf, - "\ - ", + "
\ +

\ + Rustdoc settings\ +

\ + \ + \ + Back\ + \ + \ +
\ + \ + ", root_path = page.static_root_path.unwrap_or(""), suffix = page.resource_suffix, ) diff --git a/src/librustdoc/html/static/js/settings.js b/src/librustdoc/html/static/js/settings.js index 2e2305029cddd..8770cc3f3b149 100644 --- a/src/librustdoc/html/static/js/settings.js +++ b/src/librustdoc/html/static/js/settings.js @@ -206,22 +206,8 @@ ]; // Then we build the DOM. - let innerHTML = ""; - let elementKind = "div"; - - if (isSettingsPage) { - elementKind = "section"; - innerHTML = `
-

- Rustdoc settings -

- - Back - -
`; - } - innerHTML += `
${buildSettingsPageSections(settings)}
`; - + const elementKind = isSettingsPage ? "section" : "div"; + const innerHTML = `
${buildSettingsPageSections(settings)}
`; const el = document.createElement(elementKind); el.id = "settings"; el.innerHTML = innerHTML; From 30b536e2c5ea9dc52eae72dee4a377a15e508910 Mon Sep 17 00:00:00 2001 From: Guillaume Gomez Date: Wed, 18 May 2022 11:40:29 +0200 Subject: [PATCH 2/2] Update browser-ui-test version --- .../docker/host-x86_64/x86_64-gnu-tools/browser-ui-test.version | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ci/docker/host-x86_64/x86_64-gnu-tools/browser-ui-test.version b/src/ci/docker/host-x86_64/x86_64-gnu-tools/browser-ui-test.version index f76f9131742ee..b3ec1638fda74 100644 --- a/src/ci/docker/host-x86_64/x86_64-gnu-tools/browser-ui-test.version +++ b/src/ci/docker/host-x86_64/x86_64-gnu-tools/browser-ui-test.version @@ -1 +1 @@ -0.9.2 \ No newline at end of file +0.9.3 \ No newline at end of file