From 5f3aa97650b5bdcde26d41ba93a30095c292ac1c Mon Sep 17 00:00:00 2001 From: checkraisefold Date: Sun, 27 Oct 2024 10:23:56 -0700 Subject: [PATCH] review fix --- src/operations/Completion.cpp | 14 ++------------ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/src/operations/Completion.cpp b/src/operations/Completion.cpp index 8c7c2b0f..681a587b 100644 --- a/src/operations/Completion.cpp +++ b/src/operations/Completion.cpp @@ -375,19 +375,9 @@ std::optional WorkspaceFolder::getDocumentationForAutocompleteEntry // parentTy might be an intersected type, find the actual base ttv auto followedTy = Luau::follow(*parentTy); if (auto propInformation = lookupProp(followedTy, name)) - definitionModuleName = Luau::getDefinitionModuleName(propInformation->first); + definitionModuleName = lookupTypeDefinitionModule(propInformation->first); else - definitionModuleName = Luau::getDefinitionModuleName(followedTy); - - // TODO: Dirty hack for invalid definitionModuleName on type aliases for solver v2! - // Remove after https://github.com/luau-lang/luau/issues/1441 is closed! - if (FFlag::LuauSolverV2 && !definitionModuleName) - { - if (followedTy->owningArena && followedTy->owningArena->owningModule) - { - definitionModuleName = followedTy->owningArena->owningModule->name; - } - } + definitionModuleName = lookupTypeDefinitionModule(followedTy); } } }