fix: Removed revert confirmation alert (close #395) (#396)

JohnstonCode · Oct 25, 2018 · 4dce3c9 · 4dce3c9
1 parent 6d67ba4
commit 4dce3c9
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 11 deletions.
diff --git a/package.json b/package.json
@@ -606,7 +606,7 @@
         {
           "command": "svn.revertSelectedRanges",
           "group": "2_svn@3",
-          "when": "config.svn.enabled && svnOpenRepositoryCount != 0 && isInDiffEditor && resourceScheme != merge-conflicts.conflicts-diff && && svnHasSupportToRegisterDiffCommand == 1"
+          "when": "config.svn.enabled && svnOpenRepositoryCount != 0 && isInDiffEditor && resourceScheme != merge-conflicts.conflicts-diff && svnHasSupportToRegisterDiffCommand == 1"
         }
       ],
       "explorer/context": [

diff --git a/src/commands/command.ts b/src/commands/command.ts
@@ -38,10 +38,9 @@ export abstract class Command implements Disposable {
     }
 
     if (options.diff && hasSupportToRegisterDiffCommand()) {
-      const command = this.createRepositoryCommand(this.execute);
       this._disposable = commands.registerDiffInformationCommand(
         commandName,
-        command
+        (...args: any[]) => this.execute(...args)
       );
       return;
     }
@@ -437,14 +436,6 @@ export abstract class Command implements Disposable {
       ref: "BASE"
     });
     const originalDocument = await workspace.openTextDocument(originalUri);
-    const basename = path.basename(modifiedUri.fsPath);
-    const message = `Are you sure you want to revert the selected changes in ${basename}?`;
-    const yes = "Revert Changes";
-    const pick = await window.showWarningMessage(message, { modal: true }, yes);
-
-    if (pick !== yes) {
-      return;
-    }
 
     const result = applyLineChanges(
       originalDocument,