-
-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
File / folder history support #305
Comments
@Yanpas I think implementing it in a list-view would get cramped. It would be a lot of work to implement it. I am currently working on the list-view stuff for incoming changes. It can be added the pile of features requested. Not sure when/if it will ever be done tho. |
I don't have expirience in web and currently don't have much time. Maybe I'll open PR later. GitHistory is implemented using react (jsx + tsx), not sure if we need react as a dependency, may be plain html will be enough. |
Yeah, time is always an issue. Think the use of React is to ease the burden of all the events it has to manage. |
@JohnstonCode , I've started implementing this feature in my branch https://github.com/Yanpas/svn-scm/tree/history Currently I'm facing this issue. All svn-functions are async and called after events occurence from the event-loop. Message-passing between webview and extension process is done by |
@Yanpas can you give me some idea of what you are trying to do so i can better assist you? Like an example of a problem you are trying to solve. |
I'm implementing a webview similar to "Git history" one. This view and extension may be represented as a web frontend and backend. The frontend needs to obtain the history of commits to display it and to obtain details of each commit. Now I am trying to send a list of commits to the webview. I may send it all at once, but it may be too expensive, so there should be some paging. |
After searching across github repositories I found only one soultion: |
VSCode to Webview: Webview to VSCode: |
Thanks for assistance! My question was how to pass async callback to |
Two way. Like: webview.onDidReceiveMessage(message => {
asyncTask.then(result => {
webview.postMessage({ command: 'xxxx', result: result })
})
}) In webview use only the |
then just returns new Promise, which won't be resolved in the event loop. AFAIK await is just syntatic sugar around Promise. |
I was using gitlens for some time and it feels much more handy than git-history extension. I think I'll start over with something similar. |
@Yanpas can this be closed now? |
Yep |
There is git history extension. It would be nice to have something similar for SVN.

I see it as HTML page with list of revisions with messages and dates. After clicking on list item you can see files changed and diff each file with previous revision or open it.
Alternatively it may be implmented as a second list-view in VCS pane . Mad skillz :D

The text was updated successfully, but these errors were encountered: