Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Manage account] Issue with username Validation in Manage Profile page #3730

Open
olgapod opened this issue Nov 18, 2024 · 2 comments · May be fixed by #3952
Open

[Manage account] Issue with username Validation in Manage Profile page #3730

olgapod opened this issue Nov 18, 2024 · 2 comments · May be fixed by #3952
Assignees
Labels
bug Something isn't working needs more info The issue requires more information in order to be resolved.

Comments

@olgapod
Copy link
Contributor

olgapod commented Nov 18, 2024

Description:
The Manage Profile page’s username field has a restriction allowing changes only once every 90 days. However, in the process of e2e testing, an issue was discovered where the validation isn't working in some cases.

Reproducing this issue manually is challenging without modifying the source code to override the 90-day restriction. Take the steps below to replicate the issue (not waiting for 90 days to pass).

Prerequisites:

• Update the source code to make the username editable:

  1. Navigate to:
    src/components/frame/v5/pages/UserProfilePage/partials/UserAccountPage/hooks.tsx
  2. Modify line 31 to:

return { canChangeUsername: true, daysTillUsernameChange: 91 };

Steps to reproduce

  1. Log in using Dev Wallet 2 account.
  2. Navigate to the Manage Profile page.
  3. In the username field, enter a username that is already taken (e.g., “leela”).
  4. Observe that the field provides feedback indicating the username is not available.
  5. Click the Save Changes button.
  6. Click the Save Changes button again.

Scenarios 2

  1. Log in using Dev Wallet 2 account.
  2. Navigate to the Manage Profile page.
  3. In the username field, enter a New username.
  4. Observe that the field provides feedback indicating the username is available.
  5. Click the Save Changes button.

Expected behaviour

  • The system should show the validation message and prevent the username from being updated to an already-taken value.

Actual behaviour

  • The username is changed to the already-taken value, bypassing the validation.
username-validation.mov
101.mp4
@olgapod olgapod added the bug Something isn't working label Nov 18, 2024
@rumzledz
Copy link
Contributor

rumzledz commented Dec 16, 2024

After applying the code change you suggested, I'm still unable to edit the username @olgapod . Am I missing a step?

Ignore me @olgapod ! I can now edit the username field 👌

@rumzledz rumzledz added the needs more info The issue requires more information in order to be resolved. label Dec 16, 2024
@rumzledz rumzledz self-assigned this Dec 16, 2024
@rumzledz
Copy link
Contributor

This is a very very juicy bug 🐛 Well-spotted @olgapod !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs more info The issue requires more information in order to be resolved.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants