Skip to content
This repository has been archived by the owner on Feb 21, 2024. It is now read-only.

Fix latest web3 beta breaking metamask module #202

Merged
merged 6 commits into from
Feb 7, 2019

Conversation

rdig
Copy link
Member

@rdig rdig commented Feb 7, 2019

The latest web3 beta package release, 1.0.0-beta.43 breaks the purser-metamask module by removing internal API props that we rely on to hook into Metamask's UI change events (publicConfigStore)

It goes even further, and triggers a chrome extensions safety check, making signing transactions or messages virtually impossible with that version: (see MetaMask/metamask-extension#6080)

Resources must be listed in the web_accesible_resources manifest key in order to be loaded by pages outside the extension

Changed:

  • Pin web3 version to a known stable 1.0.0-beta.36
  • Refactor purser-metamask getInpageProvider helper method to be more resilient in choosing the legacy v. modern version of the injected provider
  • Add a test case to check the above refactor
  • Unrelated fix to the monorepo's NPM release script when doing a dry run

Resolves #197

@rdig rdig self-assigned this Feb 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error - Uncaught in promise (purser-metamask)
1 participant