This repository has been archived by the owner on Feb 21, 2024. It is now read-only.
Fix latest web3 beta breaking metamask module #202
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest
web3
beta package release,1.0.0-beta.43
breaks thepurser-metamask
module by removing internal API props that we rely on to hook into Metamask's UI change events (publicConfigStore
)It goes even further, and triggers a chrome extensions safety check, making signing transactions or messages virtually impossible with that version: (see MetaMask/metamask-extension#6080)
Changed:
web3
version to a known stable1.0.0-beta.36
purser-metamask
getInpageProvider
helper method to be more resilient in choosing the legacy v. modern version of the injected providerResolves #197