Skip to content

Commit

Permalink
Merge #1630: Fix get_tx_info() type hint and doc
Browse files Browse the repository at this point in the history
d9fee29 Fix get_tx_info() type hint and doc (Kristaps Kaupe)

Pull request description:

  `txid` is passed as binary `bytes` there, not hex string.

Top commit has no ACKs.

Tree-SHA512: 3e8272a5dc2291add827a06a5d0cda03652168e9d0cc3c9ec7532ace0522eef75c7e38c0dce6e665a65bb73d31579b2afda814fc18d0afcc99db311495642034
  • Loading branch information
kristapsk committed Jan 12, 2024
2 parents 7d49d54 + d9fee29 commit 3a6bea6
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/jmclient/wallet_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -365,12 +365,12 @@ def serialize_json(self, summarize=False):
json_serialized.update(self.get_fmt_balance_json())
return json_serialized

def get_tx_info(txid: str, tx_cache: Optional[dict] = None) -> Tuple[
def get_tx_info(txid: bytes, tx_cache: Optional[dict] = None) -> Tuple[
bool, int, int, dict, int, btc.CTransaction]:
"""
Retrieve some basic information about the given transaction.
:param txid: txid as hex-str
:param txid: txid as binary
:param tx_cache: optional cache (dictionary) for get_transaction results
:return: tuple
is_coinjoin: bool
Expand Down

0 comments on commit 3a6bea6

Please sign in to comment.