Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint-python.sh is broken, at least on my machine #1568

Closed
kristapsk opened this issue Oct 6, 2023 · 0 comments · Fixed by #1569
Closed

lint-python.sh is broken, at least on my machine #1568

kristapsk opened this issue Oct 6, 2023 · 0 comments · Fixed by #1569
Labels

Comments

@kristapsk
Copy link
Member

By #1484.

We didn't notice, because CI calls flake8 directly, instead of ./test/lint/lint-python.sh. Another thing to fix.

src/jmqtui/open_wallet_dialog.py:11:1: F401 'PySide2.QtCore.QDate' imported but unused
src/jmqtui/open_wallet_dialog.py:11:1: F401 'PySide2.QtCore.QDateTime' imported but unused
src/jmqtui/open_wallet_dialog.py:11:1: F401 'PySide2.QtCore.QObject' imported but unused
src/jmqtui/open_wallet_dialog.py:11:1: F401 'PySide2.QtCore.QPoint' imported but unused
src/jmqtui/open_wallet_dialog.py:11:1: F401 'PySide2.QtCore.QRect' imported but unused
src/jmqtui/open_wallet_dialog.py:11:1: F401 'PySide2.QtCore.QTime' imported but unused
src/jmqtui/open_wallet_dialog.py:11:1: F401 'PySide2.QtCore.QUrl' imported but unused
src/jmqtui/open_wallet_dialog.py:13:1: F401 'PySide2.QtGui.QConicalGradient' imported but unused
src/jmqtui/open_wallet_dialog.py:13:1: F401 'PySide2.QtGui.QCursor' imported but unused
src/jmqtui/open_wallet_dialog.py:13:1: F401 'PySide2.QtGui.QFontDatabase' imported but unused
src/jmqtui/open_wallet_dialog.py:13:1: F401 'PySide2.QtGui.QIcon' imported but unused
src/jmqtui/open_wallet_dialog.py:13:1: F401 'PySide2.QtGui.QKeySequence' imported but unused
src/jmqtui/open_wallet_dialog.py:13:1: F401 'PySide2.QtGui.QLinearGradient' imported but unused
src/jmqtui/open_wallet_dialog.py:13:1: F401 'PySide2.QtGui.QPainter' imported but unused
src/jmqtui/open_wallet_dialog.py:13:1: F401 'PySide2.QtGui.QPixmap' imported but unused
src/jmqtui/open_wallet_dialog.py:13:1: F401 'PySide2.QtGui.QRadialGradient' imported but unused
16    F401 'PySide2.QtCore.QDate' imported but unused
^---- failure generated from ./test/lint/lint-python.sh

I remember that there were some special handling for this before, because that file is auto-generated from Qt Designer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant