Reopen #341

[AdamISZ]

Copied here for convenience

Wallet jmdat file was created when testing coincontrol branch. Now copied it to a different computer and tried opening in JoinMarketQt, with current master. Unhandled error happened, Qt "JM Wallet" tab was left with "No wallet loaded..." message, but "Coins" tab shows all UTXO's of wallet. Console output:

2019-04-06 00:18:39,661 [INFO]  Detected new wallet, performing initial import
restart Bitcoin Core with -rescan if you're recovering an existing wallet from backup seed
Otherwise just restart this joinmarket application.
Unhandled Error
Traceback (most recent call last):
  File "joinmarket-qt.py", line 1766, in <module>
    sys.exit(app.exec_())
  File "/home/neonz/git/joinmarket-clientserver/jmvenv/lib/python3.6/site-packages/qt5reactor/core.py", line 292, in iterate_qt
    self.iterate(delay=delay, fromqt=True)
  File "/home/neonz/git/joinmarket-clientserver/jmvenv/lib/python3.6/site-packages/qt5reactor/core.py", line 286, in _iterate
    self.runUntilCurrent()
--- <exception caught here> ---
  File "/home/neonz/git/joinmarket-clientserver/jmvenv/lib/python3.6/site-packages/twisted/internet/base.py", line 902, in runUntilCurrent
    call.func(*call.args, **call.kw)
  File "joinmarket-qt.py", line 1521, in syncWalletUpdate
    restart_cb=restart_cb)
  File "/fast_home/neonz/git/joinmarket-clientserver/jmclient/jmclient/blockchaininterface.py", line 399, in sync_wallet
    self.sync_wallet_fast(wallet)
  File "/fast_home/neonz/git/joinmarket-clientserver/jmclient/jmclient/blockchaininterface.py", line 411, in sync_wallet_fast
    self.get_address_usages(wallet)
  File "/fast_home/neonz/git/joinmarket-clientserver/jmclient/jmclient/blockchaininterface.py", line 439, in get_address_usages
    self.sync_addresses(wallet)
  File "/fast_home/neonz/git/joinmarket-clientserver/jmclient/jmclient/blockchaininterface.py", line 514, in sync_addresses
    wallet_name, restart_cb)
  File "/fast_home/neonz/git/joinmarket-clientserver/jmclient/jmclient/blockchaininterface.py", line 393, in add_watchonly_addresses
    sys.exit(0)
builtins.SystemExit: 0

Also, coins aren't imported into Bitcoin Core, bitcoin-cli listunspent does not show them.

Then I did restart Bitcoin Core and also JoinMarketQt and did open the same wallet file again. Now JoinMarketQt again outputted initial wallet imported message in console, shows that wallet is empty, "JM Wallet" tab does not show used addresses and starts showing generated mixdepth(s) addresses only after the used coins and "Coins" tab shows "No coins". But both bitcoin-qt and bitcoin-cli listunspent 0 9999999 now shows only one watch-only UTXO from that wallet, the one which is still unconfirmed for some days.

wallet-tool.py display shows that one address which was imported into Bitcoin Core with correct amount, with displayall I can also get non-imported addresse(s), which are correct, but, obviously with zero amounts in them, as they aren't imported into Bitcoin Core.

Not a coin loss issue, as I have privkeys and the same wallet working on another computer, but could be stressful for less experienced users who for some strange reason :), could decide to do the same thing as I did. Anyway, even at least some shitty GUI error message in JoinMarketQt would be better than current behaviour.

[AdamISZ]

We have to find a way to fix this without breaking initial load and deposit, see #392

[kristapsk]

#341 (just to have reference link here and there, Github does not track title, there are more details there)

[AdamISZ]

I've reviewed this again, and as I see it there were two problems arising out of #341 - the first was just a user error, i.e. not realising that a rescan was needed (see later on in that thread), the second was the crash due to not having the restart_callback set up. The latter is fixed after #359 , in particular see this line.

I don't believe there are any more issues, hence closing this and the PR #394 - but @kristapsk or others, feel free to reopen if there is still a problem directly related to this (opening a wallet that's not new but not locally imported, in Qt).