WIP DO NOT MERGE: Ensure non-null restart callback ... #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... always passed to add_watchonly_addresses.
As per title, basically adding the restart callback path via the fast sync also.
Not tested yet, but the idea is that it removes the conditions of #393 to occur, but I'm not yet fully satisfied (even if it tests OK) because there is still no fundamental way to distinguish between when wallet->load is loading an old but not imported here, wallet, and a currently imported here, wallet.
The latter should use fast because it's much quicker and more reliable, but the former cannot. We probably just need a way for the code to recognize a flag that says "fast sync didn't work", and then switch to detailed sync, in that case, under the hood - and it must remember to do the detailed sync over several iterations, as the CLI scripts do.