-
Notifications
You must be signed in to change notification settings - Fork 119
Sendpayment: bad-txns-inputs-duplicate #443
Comments
Can you show us the raw transaction ? It has no compromising information, if it worked you would've broadcasted it to every node in the bitcoin network. |
|
Doesn't seem obviously wrong. I noticed this which is a bit weird
|
Inputs 2 and 3 are identical. This situation is rare, but could happen if two (or more!) participants in the transaction are using the same wallet. |
Oh great. That could be something that is checked in the taker code. |
I wasn't running a yield-gen, so I guess the maker was running two yieldgens on the same wallet? |
Yeah seems so |
This should be fixed by the taker checking for duplicate UTXOs. |
I think this might be relevant to this issue. My log from yield generator on windows 10 as well as this error in bitcoin core:
|
Linking to #693, that issue causes this bug/crash. |
For posterity: also experienced the issue discussed here (this issue probably a better description); was happening as a result of trying to join with my own maker bot. |
@mecampbellsoup One way to reduce the chance of this happening when creating "self joins" is to mess with the |
@adlai make it more or less greedy? |
Leave one as default, and make the other greediest. It doesn't quite matter which (taker or maker) uses which (algorithm), although since the taker needs more inputs (to cover fees), it might make sense to make the taker be the greedy one. I'm not certain that this will always pick distinct sets, although off the top of my head, the only situation I can imagine where it wouldn't, is one where your wallet doesn't have enough coins for the entire transaction anyway. |
This happened on a desktop PC, not on a Pi.
The addresses in that mixdepth had no uncomfirmed txes.
Before this, I ran the same sendpayment but with the exact same amount that was held in that mixdepth so it crashed because of with insufficient funds.
Full blockchain, not a pruned one.
bitcoin-0.12.0/bin/bitcoin-qt -datadir=xxx &
The text was updated successfully, but these errors were encountered: