We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Other (please specify)
Instead of instantiating new Loggers in each method and passing references around, allLogger methods should be converted to macros that:
Logger
verbosity
RUST_LOG
heimdall-cli
Ex: https://github.com/Jon-Becker/heimdall-rs/blob/main/common/src/utils/io/macros.rs Then, the PR should delete all instances of Logger. Trace TraceFactory still make sense in their current implementations, so these structs should be preserved.
Trace
TraceFactory
The text was updated successfully, but these errors were encountered:
I'll take this one 😄
Sorry, something went wrong.
iankressin
No branches or pull requests
Component
Other (please specify)
Describe the feature you would like
Instead of instantiating new
Logger
s in each method and passing references around, allLogger
methods should be converted to macros that:verbosity
from theRUST_LOG
environment variable (this is set byheimdall-cli
, so it's accurate)verbosity
is greater minimum verbosity for that log. (error >= 0, warn >= 1, info >= 2, etc.)a. if it is, send the log
b. if not, return!
Ex: https://github.com/Jon-Becker/heimdall-rs/blob/main/common/src/utils/io/macros.rs
Then, the PR should delete all instances of
Logger
.Trace
TraceFactory
still make sense in their current implementations, so these structs should be preserved.The text was updated successfully, but these errors were encountered: