Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace snippets with new heimdall-common functions #240

Closed
iankressin opened this issue Dec 14, 2023 · 0 comments · Fixed by #241
Closed

Replace snippets with new heimdall-common functions #240

iankressin opened this issue Dec 14, 2023 · 0 comments · Fixed by #241
Assignees
@iankressin
Labels
D-chore Difficulty: chore P-normal Priority: normal T-debt Type: code debt T-feature Type: feature

Comments

@iankressin
Copy link
Contributor

iankressin commented Dec 14, 2023 •
edited by Jon-Becker
Loading

Component

Heimdall (Core)

Describe the feature you would like

PR#198 introduced a new functions to heimdall-common module

We should replace the repeated code snippets for these functions across the entire codebase
@iankressin iankressin added the T-feature Type: feature label Dec 14, 2023
@Jon-Becker Jon-Becker changed the title Replace snippets with new heimdall::common functions Replace snippets with new heimdall-common functions Dec 14, 2023
@Jon-Becker Jon-Becker added D-chore Difficulty: chore T-debt Type: code debt labels Dec 14, 2023
@Jon-Becker Jon-Becker added the P-normal Priority: normal label Dec 14, 2023
@iankressin iankressin mentioned this issue Dec 14, 2023
Merged
@Jon-Becker Jon-Becker linked a pull request Dec 16, 2023 that will close this issue
chore: heimdall-common replacements #241
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iankressin iankressin

Labels
D-chore Difficulty: chore P-normal Priority: normal T-debt Type: code debt T-feature Type: feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: heimdall-common replacements iankressin/heimdall-rs
2 participants
@iankressin @Jon-Becker