Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spell Checker Fails #69

Closed
shoesforindustry opened this issue Dec 8, 2015 · 11 comments
Closed

Spell Checker Fails #69

shoesforindustry opened this issue Dec 8, 2015 · 11 comments

Comments

@shoesforindustry
Copy link

In Firefox Mac, there is no ''right-click' spell checker when using this field, reverting to textarea the spell checker is back?

@JonasDoebertin
Copy link
Owner

Isn't this the normal behavior? It's the same for me using Chrome with any "contentEditable" powered editor/input.

Spell check does work on regular textareas only, doesn't it?

@shoesforindustry
Copy link
Author

I did think it used to work? I'm sure it did with other editors?

@1n3JgKl9pQ6cUMrW
Copy link

It's an interesting issue; the default WYSIWYG editor in Wordpress has spell-check, but something like CKEditor not - http://ckeditor.com/demo

@shoesforindustry
Copy link
Author

Sadly yes, I love Visual Markdown, but my spelling is so bad...

@JonasDoebertin
Copy link
Owner

Hmmm. I guess this is something I have to investigate further. I'll leave this open for now.

@shoesforindustry
Copy link
Author

Some editors seems to have their own spell checker, but I think using the default one is probably best?
I leave it in your capable hands...

@JonasDoebertin
Copy link
Owner

Just did a quick search and came to the following conclusion:

  • Browser based spell checking does in fact work on input and contentEditable elements
  • CodeMirror (what Visual Markdown Editor is based on) doesn't use contentEditable elements at all so there's no way of getting browser based spell checking to work
  • One could integrate a custom, JS based, spell checking library with CodeMirror using overlays, but that would, probably, affect performance and file size massively

Related topic: codemirror/codemirror5#1017

@1n3JgKl9pQ6cUMrW
Copy link

Strange thing is that the manual refers to a spell-check option;

http://codemirror.net/1/manual.html

disableSpellcheck

Should the editor disable spell-checking on browsers that support it (Firefox 2+).
Default is true, since for most code spell-checking is useless.
Can be changed with the setSpellCheck(on) method.

I tried this option (setSpellCheck(on)) but it didn't work out for me.

There are also some plugins;

@JonasDoebertin
Copy link
Owner

The manual link you posted is really outdated. It refers to an old version of CodeMirror from a time when it was using a contentEditable element.

@1n3JgKl9pQ6cUMrW
Copy link

Okay - I will not digg in it further more.

The most easy thing is to add a code-toggle button to the toolbar, which makes the textarea visible.

image

This one shows the typo's you made - so you can correct them and hide the raw-code by clicking on the button again.

Don't know this is helpfull...

@JonasDoebertin
Copy link
Owner

Seems like there is no solution to use the browsers default spell check with CodeMirror. Closing this for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants