Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing parameter? when cold starting #105

Closed
laguerreuy opened this issue Aug 19, 2021 · 2 comments
Closed

Missing parameter? when cold starting #105

laguerreuy opened this issue Aug 19, 2021 · 2 comments
Labels
T: Fix Type: :bug: Bug Fixes

Comments

@laguerreuy
Copy link

Describe the bug
I get this issue when trying to start for the first time

AppData/Local/Pub/Cache/hosted/pub.dartlang.org/timetable-1.0.0-alpha.5/lib/src/time/zoom.dart:621:43: Error: Too few positional arguments: 2 required, 1 given.
focalPointDelta > computeHitSlop(pointerDeviceKind))

The problem is fixed if I add null as second parameter. I updated the code as follows:

  _if (spanDelta > computeScaleSlop(pointerDeviceKind) ||
      focalPointDelta > computeHitSlop(pointerDeviceKind, null))_

My programming skills are basic, please ignore if the issue is caused by a mistake on my side. I would appreciate some guide in that case.

Environment:

  • Device: <Mi Note 10>
  • OS version: <Android 11>
@laguerreuy laguerreuy added the T: Fix Type: :bug: Bug Fixes label Aug 19, 2021
@JonasWanke
Copy link
Owner

This seems to be a breaking change introduced in flutter/flutter#87604 – I'm guessing your Flutter channel is master or dev? Using null as the second parameter should be fine. I'll have a closer look and publish the fix the week after next.

@JonasWanke
Copy link
Owner

Fixed and published as part of v1.0.0-alpha.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T: Fix Type: :bug: Bug Fixes
Projects
None yet
Development

No branches or pull requests

2 participants