Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bevy-0.12] Migrate to Interned ScheduleLabels #204

Merged
merged 2 commits into from
Oct 30, 2023

Conversation

atlv24
Copy link

@atlv24 atlv24 commented Oct 28, 2023

For Bevy 0.12

the only sketchy thing here is setup.rs:128

let fixed_update = schedule == FixedUpdate.intern();

@Jondolf
Copy link
Owner

Jondolf commented Oct 28, 2023

Thanks! CI is failing, but it's probably because I haven't done the rest of the migration properly yet, and some things seem to have changed on Bevy main. I'll do it today though (Edit: I did in fact not do it that day, I was busy with other work. I'll do it very soon™ though)

@Jondolf
Copy link
Owner

Jondolf commented Oct 30, 2023

I'll merge this since we need to do this for the migration anyway, and fix the remaining issues (+ verify the fixed update check) in the base migration PR

@Jondolf Jondolf merged commit 0df7617 into Jondolf:bevy-0.12 Oct 30, 2023
0 of 4 checks passed
@Jondolf
Copy link
Owner

Jondolf commented Oct 30, 2023

Btw I tested and the fixed update check does seem to work, it's consistently returning true when running physics in FixedUpdate and false otherwise

@Jondolf Jondolf mentioned this pull request Oct 30, 2023
Jondolf added a commit that referenced this pull request Nov 4, 2023
# Objective

Add Bevy 0.12 support.

## Solution

- Update Bevy (and Criterion)
- Migrate to `Interned` `ScheduleLabel`s (#204)
- Fix deprecated methods
- Unify time and simulation loop APIs under `Time<Physics>` and `Time<Substeps>` (#214)
- Update `README.md` (and its feature list)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants