Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify physics time APIs with Time<Physics> and Time<Substeps> #214

Merged
merged 14 commits into from
Nov 3, 2023
Merged

Unify physics time APIs with Time<Physics> and Time<Substeps> #214

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
c3710a0
Replace time resources with `Time<Physics>` and `Time<Substeps>`
Jondolf Oct 31, 2023
b27370f
Replace time resources with `Time<Physics>` and `Time<Substeps>`
Jondolf Oct 31, 2023
17aaf8b
Merge branch 'physics-clocks' of https://github.com/Jondolf/bevy_xpbd…
Jondolf Oct 31, 2023
df4c924
Change default timestep back to fixed 60 Hz
Jondolf Nov 1, 2023
bd1c512
Update snapshot and fix doc test
Jondolf Nov 1, 2023
dd2988f
Add helpers for creating `Physics` clocks and add docs
Jondolf Nov 1, 2023
976e786
Use `fixed_hz` in `Physics::default`
Jondolf Nov 1, 2023
e5717e3
Fix doc test imports
Jondolf Nov 1, 2023
8092899
Use `Time<Real>` instead of `Time<Virtual>` for `Time<Physics>`
Jondolf Nov 1, 2023
06cec45
Remove `PhysicsTimescale` and `PhysicsLoop` in favor of `Time<Physics>`
Jondolf Nov 3, 2023
6d33f6d
Fix example warnings
Jondolf Nov 3, 2023
24dd997
Improve `Time<Physics>` docs
Jondolf Nov 3, 2023
bb7fc80
Fix doc links
Jondolf Nov 3, 2023
e9927e1
Revert to old fixed timestep behavior
Jondolf Nov 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/benches_common_3d/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ pub fn bench_app<M: Measurement>(
PhysicsPlugins::default(),
));

app.insert_resource(PhysicsTimestep::FixedOnce(1.0 / 60.0));
app.insert_resource(Time::new_with(Physics::fixed_once_hz(1.0 / 60.0)));

setup(&mut app);

Expand Down
2 changes: 1 addition & 1 deletion crates/bevy_xpbd_3d/examples/basic_dynamic_character.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,7 @@ fn movement(
// both the `f32` and `f64` features. Otherwise you don't need this.
let delta_time = time.delta_seconds_f64().adjust_precision();

for event in movement_event_reader.iter() {
for event in movement_event_reader.read() {
for (movement_acceleration, jump_impulse, mut linear_velocity, is_grounded) in
&mut controllers
{
Expand Down
2 changes: 1 addition & 1 deletion crates/bevy_xpbd_3d/examples/basic_kinematic_character.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,7 @@ fn movement(
// both the `f32` and `f64` features. Otherwise you don't need this.
let delta_time = time.delta_seconds_f64().adjust_precision();

for event in movement_event_reader.iter() {
for event in movement_event_reader.read() {
for (movement_acceleration, jump_impulse, mut linear_velocity, is_grounded) in
&mut controllers
{
Expand Down
Loading