Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DarkElf + test notebooks #215

Merged
merged 14 commits into from
May 28, 2022
Merged

Add DarkElf + test notebooks #215

merged 14 commits into from
May 28, 2022

Conversation

JoranAngevaare
Copy link
Owner

@coveralls
Copy link

coveralls commented May 28, 2022

Pull Request Test Coverage Report for Build 2401458701

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.04%) to 94.343%

Files with Coverage Reduction New Missed Lines %
dddm/statistics.py 1 90.82%
Totals Coverage Status
Change from base Build 2373046923: 0.04%
Covered Lines: 2118
Relevant Lines: 2245

💛 - Coveralls

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented May 28, 2022

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 4.31%.

Quality metrics Before After Change
Complexity 0.57 ⭐ 0.52 ⭐ -0.05 👍
Method Length 51.22 ⭐ 39.57 ⭐ -11.65 👍
Working memory 10.39 😞 9.33 🙂 -1.06 👍
Quality 71.74% 🙂 76.05% 4.31% 👍
Other metrics Before After Change
Lines 105 63 -42
Changed files Quality Before Quality After Quality Change
tests/test_spectra.py 75.82% ⭐ 76.05% ⭐ 0.23% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
tests/test_spectra.py test_simple_spectrum 0 ⭐ 138 😞 13 😞 59.04% 🙂 Try splitting into smaller methods. Extract out complex expressions
tests/test_spectra.py _galactic_spectrum_inner 2 ⭐ 49 ⭐ 14 😞 68.04% 🙂 Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@JoranAngevaare JoranAngevaare merged commit f4a0389 into master May 28, 2022
@JoranAngevaare JoranAngevaare deleted the test_nb_and_drak_elf branch May 28, 2022 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants