-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update node version to LTS #474
Conversation
I'm going to pull this branch and run it to ensure it works, then LGTM. Also before you merge, can you please update your PR title to follow Conventional Commits syntax with a valid prefix. I think |
Co-authored-by: Jordan Foreman <thejordanforeman@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please revert aws-sdk
update
Done 🚀 |
Thanks for the awesome contribution @tiago154! |
# [1.0.0](v0.1.4...v1.0.0) (2023-10-04) * chore!: update node version to LTS (#474) ([938827d](938827d)), closes [#474](#474) ### BREAKING CHANGES * drops support for older node versions (<=10) * Update node version * Updating packages to their most current versions * Update .nvmrc Co-authored-by: Jordan Foreman <thejordanforeman@gmail.com> * Rollback the aws-sdk version
🎉 This PR is included in version 1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
#470
@JordanForeman Hi.
Changes:
Validations:
Attention points:
After the update, it ended up generating a warning from the AWS package, but I believe this change can be made more calmly later, as it is a breaking change.
Follows the changes of the updated packages, but without changes to the code behavior
NOTE: If there was any other validation or change missing, please let me know