Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update node version to LTS #474

Merged
merged 4 commits into from
Oct 4, 2023

Conversation

tiago154
Copy link
Contributor

@tiago154 tiago154 commented Oct 4, 2023

#470

@JordanForeman Hi.

Changes:

  • Update the node in the .nvmrc file to the current LTS version of the node
  • Updated project packages

Validations:

  • Validated the execution of tests
  • Checked the project lint, where there were no errors

Attention points:

After the update, it ended up generating a warning from the AWS package, but I believe this change can be made more calmly later, as it is a breaking change.

image

Follows the changes of the updated packages, but without changes to the code behavior
image

NOTE: If there was any other validation or change missing, please let me know

@JordanForeman
Copy link
Owner

I'm going to pull this branch and run it to ensure it works, then LGTM.

Also before you merge, can you please update your PR title to follow Conventional Commits syntax with a valid prefix. I think chore! is probably right here, since it's non-functional but potentially breaking on older versions of Node. I'll make sure to document this in #473 😉

@JordanForeman JordanForeman added the hacktoberfest This issue/PR is for DigitalOcean's annual Hacktoberfest event label Oct 4, 2023
.nvmrc Outdated Show resolved Hide resolved
@tiago154 tiago154 changed the title Update node version to LTS chore: update node version to LTS Oct 4, 2023
Co-authored-by: Jordan Foreman <thejordanforeman@gmail.com>
package.json Outdated Show resolved Hide resolved
Copy link
Owner

@JordanForeman JordanForeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert aws-sdk update

@tiago154
Copy link
Contributor Author

tiago154 commented Oct 4, 2023

Please revert aws-sdk update

Done 🚀

@JordanForeman JordanForeman merged commit 938827d into JordanForeman:master Oct 4, 2023
1 check passed
@JordanForeman
Copy link
Owner

Thanks for the awesome contribution @tiago154!

This was referenced Oct 4, 2023
JordanForeman pushed a commit that referenced this pull request Oct 4, 2023
# [1.0.0](v0.1.4...v1.0.0) (2023-10-04)

* chore!: update node version to LTS (#474) ([938827d](938827d)), closes [#474](#474)

### BREAKING CHANGES

* drops support for older node versions (<=10)

* Update node version

* Updating packages to their most current versions

* Update .nvmrc

Co-authored-by: Jordan Foreman <thejordanforeman@gmail.com>

* Rollback the aws-sdk version
@JordanForeman
Copy link
Owner

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest This issue/PR is for DigitalOcean's annual Hacktoberfest event released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants