Analyzers that require option to be set should disabled by default (R…

…CS1018, RCS1096, RCS1250)
dotnet · Jan 28, 2022 · de37485 · de37485
1 parent 199787b
commit de37485
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 12 deletions.
diff --git a/docs/Configuration.md b/docs/Configuration.md
@@ -360,7 +360,7 @@ dotnet_diagnostic.rcs1016.severity = none
 # Options: roslynator_body_style, roslynator_use_block_body_when_declaration_spans_over_multiple_lines, roslynator_use_block_body_when_expression_spans_over_multiple_lines
 
 # Add/remove accessibility modifiers
-dotnet_diagnostic.rcs1018.severity = suggestion
+dotnet_diagnostic.rcs1018.severity = none
 # Options: roslynator_accessibility_modifiers
 
 # Order modifiers
@@ -531,7 +531,7 @@ dotnet_diagnostic.rcs1093.severity = suggestion
 dotnet_diagnostic.rcs1094.severity = none
 
 # Use 'HasFlag' method or bitwise operator
-dotnet_diagnostic.rcs1096.severity = suggestion
+dotnet_diagnostic.rcs1096.severity = none
 # Options: roslynator_enum_has_flag_style
 
 # Remove redundant 'ToString' call
@@ -919,7 +919,7 @@ dotnet_diagnostic.rcs1248.severity = none
 dotnet_diagnostic.rcs1249.severity = suggestion
 
 # Use implicit/explicit object creation
-dotnet_diagnostic.rcs1250.severity = suggestion
+dotnet_diagnostic.rcs1250.severity = none
 # Options: roslynator_object_creation_type_style, roslynator_use_var_instead_of_implicit_object_creation
 
 # Use pattern matching

diff --git a/src/Analyzers/Analyzers.xml b/src/Analyzers/Analyzers.xml
@@ -443,7 +443,7 @@ foreach (var item in items) // [|Id|]
     <MessageFormat>{0} accessibility modifiers.</MessageFormat>
     <Category>Readability</Category>
     <DefaultSeverity>Info</DefaultSeverity>
-    <IsEnabledByDefault>true</IsEnabledByDefault>
+    <IsEnabledByDefault>false</IsEnabledByDefault>
     <Samples>
       <Sample>
         <Before><![CDATA[class Foo // [|Id|]
@@ -2192,7 +2192,7 @@ namespace Foo
     <MessageFormat>Use {0}.</MessageFormat>
     <Category>Performance</Category>
     <DefaultSeverity>Info</DefaultSeverity>
-    <IsEnabledByDefault>true</IsEnabledByDefault>
+    <IsEnabledByDefault>false</IsEnabledByDefault>
     <Samples>
       <Sample>
         <Before><![CDATA[options.HasFlag(RegexOptions.IgnoreCase)]]></Before>
@@ -5665,7 +5665,7 @@ void M()
     <MessageFormat>Use {0} object creation.</MessageFormat>
     <Category>Roslynator</Category>
     <DefaultSeverity>Info</DefaultSeverity>
-    <IsEnabledByDefault>true</IsEnabledByDefault>
+    <IsEnabledByDefault>false</IsEnabledByDefault>
     <MinLanguageVersion>9.0</MinLanguageVersion>
     <Samples>
       <Sample>

diff --git a/src/Analyzers/CSharp/DiagnosticRules.Generated.cs b/src/Analyzers/CSharp/DiagnosticRules.Generated.cs
@@ -206,7 +206,7 @@ public static partial class DiagnosticRules
             messageFormat:      "{0} accessibility modifiers.", 
             category:           DiagnosticCategories.Roslynator, 
             defaultSeverity:    DiagnosticSeverity.Info, 
-            isEnabledByDefault: true, 
+            isEnabledByDefault: false, 
             description:        null, 
             helpLinkUri:        DiagnosticIdentifiers.AddOrRemoveAccessibilityModifiers, 
             customTags:         Array.Empty<string>());
@@ -892,7 +892,7 @@ public static partial class DiagnosticRules
             messageFormat:      "Use {0}.", 
             category:           DiagnosticCategories.Roslynator, 
             defaultSeverity:    DiagnosticSeverity.Info, 
-            isEnabledByDefault: true, 
+            isEnabledByDefault: false, 
             description:        null, 
             helpLinkUri:        DiagnosticIdentifiers.UseHasFlagMethodOrBitwiseOperator, 
             customTags:         Array.Empty<string>());
@@ -2444,7 +2444,7 @@ public static partial class DiagnosticRules
             messageFormat:      "Use {0} object creation.", 
             category:           DiagnosticCategories.Roslynator, 
             defaultSeverity:    DiagnosticSeverity.Info, 
-            isEnabledByDefault: true, 
+            isEnabledByDefault: false, 
             description:        null, 
             helpLinkUri:        DiagnosticIdentifiers.UseImplicitOrExplicitObjectCreation, 
             customTags:         Array.Empty<string>());

diff --git a/src/VisualStudioCode/package/src/configurationFiles.generated.ts b/src/VisualStudioCode/package/src/configurationFiles.generated.ts
@@ -337,7 +337,7 @@ roslynator_analyzers.enabled_by_default = true|false
 # Options: roslynator_body_style, roslynator_use_block_body_when_declaration_spans_over_multiple_lines, roslynator_use_block_body_when_expression_spans_over_multiple_lines
 
 # Add/remove accessibility modifiers
-#dotnet_diagnostic.rcs1018.severity = suggestion
+#dotnet_diagnostic.rcs1018.severity = none
 # Options: roslynator_accessibility_modifiers
 
 # Order modifiers
@@ -508,7 +508,7 @@ roslynator_analyzers.enabled_by_default = true|false
 #dotnet_diagnostic.rcs1094.severity = none
 
 # Use 'HasFlag' method or bitwise operator
-#dotnet_diagnostic.rcs1096.severity = suggestion
+#dotnet_diagnostic.rcs1096.severity = none
 # Options: roslynator_enum_has_flag_style
 
 # Remove redundant 'ToString' call
@@ -896,7 +896,7 @@ roslynator_analyzers.enabled_by_default = true|false
 #dotnet_diagnostic.rcs1249.severity = suggestion
 
 # Use implicit/explicit object creation
-#dotnet_diagnostic.rcs1250.severity = suggestion
+#dotnet_diagnostic.rcs1250.severity = none
 # Options: roslynator_object_creation_type_style, roslynator_use_var_instead_of_implicit_object_creation
 
 # Use pattern matching